Skip to content

fix(chatrelay): use chat relay for system messages#16355

Merged
miaulalala merged 2 commits intomainfrom
fix/noid/chat-relay-all-system-messages
Nov 21, 2025
Merged

fix(chatrelay): use chat relay for system messages#16355
miaulalala merged 2 commits intomainfrom
fix/noid/chat-relay-all-system-messages

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Nov 19, 2025

		'call_started',
		'call_joined',
		'call_left',
		'call_ended',
		'call_ended_everyone',
		'thread_created',
		'thread_renamed',
		'message_deleted',
		'message_edited',
		'moderator_promoted',
		'moderator_demoted',
		'guest_moderator_promoted',
		'guest_moderator_demoted',
		'file_shared',
		'object_shared',
		'history_cleared',
		'poll_voted',
		'poll_closed',
		'recording_started',
		'recording_stopped',

are all sent via signaling messages.

Polls will only contain specific votes when the poll is not anonymous, otherwise the sum of all votes will be shown.

  • Split notify methods into separate calls for chat and system messages.

🛠️ API Checklist

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@miaulalala miaulalala added this to the 🍏 Next Major (33) milestone Nov 19, 2025
@miaulalala miaulalala self-assigned this Nov 19, 2025
@miaulalala miaulalala added 3. to review feature: chat 💬 Chat and system messages feature: signaling 📶 Internal and external signaling backends labels Nov 19, 2025
@miaulalala miaulalala requested a review from Antreesy November 19, 2025 15:47
@miaulalala
Copy link
Contributor Author

/backport to stable32

@miaulalala miaulalala force-pushed the fix/noid/chat-relay-all-system-messages branch 3 times, most recently from ad0fe95 to 83fb43c Compare November 20, 2025 14:19
@miaulalala
Copy link
Contributor Author

miaulalala commented Nov 20, 2025

poll_voted send voting data (total votes and each option results) with the updated poll (If anonymous there is no poll_voted)
poll_ended send entire poll data including users ( total votes, each option results with list of voters) (if anonymous, send total votes and total number for each option)

@miaulalala miaulalala force-pushed the fix/noid/chat-relay-all-system-messages branch from 83fb43c to fbfa472 Compare November 20, 2025 15:55
@DorraJaouad
Copy link
Contributor

All listed sys messages are working, with a bonus value that poll system messages are enough to cover the poll process with no need to send a request getPollData 🔥

As a follow up and not critical, we can craft sys message chat relay thread_created so it transfer the thread object upon initialization (replacing a request getSingleThread)

@miaulalala miaulalala force-pushed the fix/noid/chat-relay-all-system-messages branch 6 times, most recently from 8966021 to 073c0e3 Compare November 20, 2025 22:39
@miaulalala miaulalala force-pushed the fix/noid/chat-relay-all-system-messages branch from 073c0e3 to ec328db Compare November 21, 2025 12:27
```
		'call_started',
		'call_joined',
		'call_left',
		'call_ended',
		'call_ended_everyone',
		'thread_created',
		'thread_renamed',
		'message_deleted',
		'message_edited',
		'moderator_promoted',
		'moderator_demoted',
		'guest_moderator_promoted',
		'guest_moderator_demoted',
		'file_shared',
		'object_shared',
		'history_cleared',
		'poll_voted',
		'poll_closed',
		'recording_started',
		'recording_stopped',
```

are all sent via signaling messages.

Polls will only contain specific votes when the poll is not anonymous, otherwise the sum of all votes will be shown.

- Split notify methods into separate calls for chat and system messages.

Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/noid/chat-relay-all-system-messages branch from 4c10a99 to abad373 Compare November 21, 2025 13:15
@miaulalala miaulalala enabled auto-merge November 21, 2025 13:16
@miaulalala miaulalala merged commit 6abf123 into main Nov 21, 2025
82 checks passed
@miaulalala miaulalala deleted the fix/noid/chat-relay-all-system-messages branch November 21, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: chat 💬 Chat and system messages feature: signaling 📶 Internal and external signaling backends

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants