fix(chatrelay): use chat relay for system messages#16355
Merged
miaulalala merged 2 commits intomainfrom Nov 21, 2025
Merged
Conversation
Contributor
Author
|
/backport to stable32 |
ad0fe95 to
83fb43c
Compare
Contributor
Author
|
|
nickvergessen
approved these changes
Nov 20, 2025
83fb43c to
fbfa472
Compare
Contributor
|
All listed sys messages are working, with a bonus value that poll system messages are enough to cover the poll process with no need to send a request getPollData 🔥 As a follow up and not critical, we can craft sys message chat relay thread_created so it transfer the thread object upon initialization (replacing a request getSingleThread) |
8966021 to
073c0e3
Compare
073c0e3 to
ec328db
Compare
DorraJaouad
approved these changes
Nov 21, 2025
``` 'call_started', 'call_joined', 'call_left', 'call_ended', 'call_ended_everyone', 'thread_created', 'thread_renamed', 'message_deleted', 'message_edited', 'moderator_promoted', 'moderator_demoted', 'guest_moderator_promoted', 'guest_moderator_demoted', 'file_shared', 'object_shared', 'history_cleared', 'poll_voted', 'poll_closed', 'recording_started', 'recording_stopped', ``` are all sent via signaling messages. Polls will only contain specific votes when the poll is not anonymous, otherwise the sum of all votes will be shown. - Split notify methods into separate calls for chat and system messages. Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
4c10a99 to
abad373
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
are all sent via signaling messages.
Polls will only contain specific votes when the poll is not anonymous, otherwise the sum of all votes will be shown.
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required