Skip to content

Comments

fix: manage existing breakout rooms from conversation settings#16728

Merged
Antreesy merged 2 commits intomainfrom
fix/16726/manage-breakout-rooms
Feb 2, 2026
Merged

fix: manage existing breakout rooms from conversation settings#16728
Antreesy merged 2 commits intomainfrom
fix/16726/manage-breakout-rooms

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jan 15, 2026

☑️ Resolves

  • Fix Add additional breakout rooms #16726
    • Already configured rooms should show the participants editor / manager to move them across rooms, or delete all rooms
    • Logic, styles and strings copied from Right sidebar > Breakout rooms action
    • Modals are now mounted inside the conversation settings dialog - so should not be behind

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🍏 Next Beta (33) milestone Jan 15, 2026
@Antreesy Antreesy requested review from ShGKme and Copilot January 15, 2026 10:03
@Antreesy Antreesy self-assigned this Jan 15, 2026
@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 15, 2026

/backport to stable32

@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 15, 2026

/backport to stable31

This comment was marked as resolved.

Sign in to view

@Antreesy Antreesy force-pushed the fix/16726/manage-breakout-rooms branch from e9ac948 to 5759e7a Compare January 15, 2026 10:35
@Antreesy
Copy link
Contributor Author

Antreesy commented Jan 15, 2026

Great, I misclicked on PR creation and it's still following me 🙈

@Antreesy Antreesy requested a review from DorraJaouad January 28, 2026 11:20
@Antreesy Antreesy force-pushed the fix/16726/manage-breakout-rooms branch from 5759e7a to a8035d8 Compare February 2, 2026 11:04
DorraJaouad
DorraJaouad approved these changes Feb 2, 2026
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all good

@Antreesy Antreesy force-pushed the fix/16726/manage-breakout-rooms branch from a8035d8 to 46f6272 Compare February 2, 2026 16:35
@Antreesy
fix: manage existing breakout rooms from conversation settings
e46b0ed 
- logic copied from BreakoutRoomsTab

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(BreakoutRoomsEditor): show nested modal on top of settings dialog
a4001dd 
- also drop redundant prop and fix appearance

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/16726/manage-breakout-rooms branch from 46f6272 to a4001dd Compare February 2, 2026 16:40
@Antreesy
Copy link
Contributor Author

Antreesy commented Feb 2, 2026

/backport to stable33

@Antreesy Antreesy merged commit a99566e into main Feb 2, 2026
57 checks passed
@Antreesy Antreesy deleted the fix/16726/manage-breakout-rooms branch February 2, 2026 16:55
@backportbot backportbot bot mentioned this pull request Feb 2, 2026
Merged
This was referenced Feb 2, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Antreesy Antreesy

Labels

bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

🏖️ Next Major (34)

Development

Successfully merging this pull request may close these issues.

Add additional breakout rooms

3 participants

@Antreesy @DorraJaouad @nickvergessen