Skip to content

perf(sharing): Split getShareWith() and shortcut the happy path with $path#17094

Merged
nickvergessen merged 7 commits intomainfrom
perf/17091/split-getShareWith-and-shortcut-happy-path
Feb 13, 2026
Merged

perf(sharing): Split getShareWith() and shortcut the happy path with $path#17094
nickvergessen merged 7 commits intomainfrom
perf/17091/split-getShareWith-and-shortcut-happy-path

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 13, 2026 •
edited
Loading

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen marked this pull request as draft February 13, 2026 11:25
@nickvergessen nickvergessen force-pushed the perf/17091/split-getShareWith-and-shortcut-happy-path branch from ada2674 to dc5e3c6 Compare February 13, 2026 12:36
nickvergessen and others added 5 commits February 13, 2026 14:08
@nickvergessen
perf(sharing): Use already left joined child share data or generate f…
3a78417 
…rom parent

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
perf(sharing): Remove dead code path from resolveSharesForRecipient()
6f17844 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@artonge @nickvergessen
fix(sharing): Use placeholder in no-children branch
64a6327 
Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge @nickvergessen
fix(files_sharing): Filter by path earlier
6baf7f9 
Signed-off-by: Louis Chmn <louis@chmn.me>
@nickvergessen
perf(sharing): Split getShareWith() and shortcut the happy path with …
0dcc415 
…$path

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the perf/17091/split-getShareWith-and-shortcut-happy-path branch from dc5e3c6 to 0dcc415 Compare February 13, 2026 13:08
@nickvergessen nickvergessen changed the title Perf/17091/split get share with and shortcut happy path perf(sharing): Split getShareWith() and shortcut the happy path with $path Feb 13, 2026
@nickvergessen nickvergessen requested review from artonge and salmart-dev and removed request for salmart-dev February 13, 2026 13:08
@nickvergessen nickvergessen self-assigned this Feb 13, 2026
@nickvergessen nickvergessen added feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings performance 🚀 labels Feb 13, 2026
@nickvergessen nickvergessen added this to the 🏖️ Next Major (34) milestone Feb 13, 2026
@nickvergessen nickvergessen marked this pull request as ready for review February 13, 2026 13:09
@nickvergessen
fix(sharing): Remove unreachable paths
f068b58 
Signed-off-by: Joas Schilling <coding@schilljs.com>
artonge
artonge reviewed Feb 13, 2026
View reviewed changes
@nickvergessen
perf(sharing): Add a lightweight query to check if user is in a room
d0e08ee 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@artonge
Copy link
Contributor

artonge commented Feb 13, 2026

/backport to stable33

@nickvergessen nickvergessen merged commit de7aa3d into main Feb 13, 2026
83 checks passed
@nickvergessen nickvergessen deleted the perf/17091/split-getShareWith-and-shortcut-happy-path branch February 13, 2026 14:54
@backportbot backportbot bot mentioned this pull request Feb 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@salmart-dev salmart-dev Awaiting requested review from salmart-dev

Assignees

@nickvergessen nickvergessen

Labels

feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings performance 🚀

Projects

None yet

Milestone

🏖️ Next Major (34)

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @artonge @salmart-dev