Adjust room name input to default height for inputs from server #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Nextcloud 16 the default height for input elements, as well as the confirm icons inside them, is 34px. This caused the room name input to change its height from 44px to 42px, so it is no longer needed to pull it up 2px to prevent moving the items below when it is shown. In a similar way, it also caused the confirm icon to change its height from 42px to 34px; it was misplaced down 1px, so now it is positioned 4px from the top (instead of 5px to keep the same position as before). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Ivansss
approved these changes
Apr 11, 2019
nickvergessen
deleted the
adjust-room-name-input-to-default-height-for-inputs-from-server
branch
|
/backport to stable16 |
|
backport to stable16 in #1717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default height for input elements, as well as the confirm icons inside them, has been changed in server to 34px for Nextcloud 16; this pull request adjusts the room name input to that new height.
Before:
After: (hard to see, but now the elements below it are not moved when the input field is shown)
