[stable16] Fixes for keyboard navigation #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The tab headers contain a link that was focusable using keyboard navigation. However, the CSS styles that highlight the tab header were associated to the whole tab header, so even if the link was focused the tab header was not highlighted. Now the link is no longer focusable and the tab header itself is the element that gets the focus, which causes it to be highlighted when navigating with the keyboard. Also, the same selection behaviour applied when the tab header is clicked is now applied when pressing space or enter. Finally, as the tab header can not be selected again when it is already selected the tab header is not focusable either when it is already selected. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The select2 containers have the same size as the "oca-spreedme-add-XXX" wrappers that contain them, so the borders can be moved from those wrappers to the containers themselves. This makes possible to set a stronger border when the select2 container is active/focused. Besides that now the text is stronger too when the select2 container is focused to show that more clearly. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "copy link" button was not an actual button but a span, so it was ignored in keyboard navigation. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The edit button was not an actual button but a span, so it was ignored in keyboard navigation. Moreover, the opacity was applied to its parent element instead of to the button itself, so it was not highlighted when focused. Also, after the input is hidden now the focus is given back to the edit button. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The sidebar trigger was not an actual button but a div, so it was ignored in keyboard navigation. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The password button was not an actual button but a span, so it was ignored in keyboard navigation. Also, after the password menu is hidden now the focus is given back to the password button. The button was also wrapped in a div with the "menutoggle" CSS class, which causes the menu to be hidden when clicking again on the toggle. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The participant items were link elements, so they were taken into account in keyboard navigation. However, although it is possible to interact with some of its children, it is not possible to interact with the participant item as a whole, so they should not be focusable. As the link in the participant items led nowhere they are now simple span elements instead of links. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
delete-merged-branch
bot
deleted the
backport/2122/stable16-fixes-for-keyboard-navigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2122
It had to be done manually because #1822 is Talk 7 only; I just changed one CSS locator and dropped three commits.