[stable17] Do not immediately join the conversation in Files app #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before as soon as the chat tab loaded if the file was shared the user automatically joined the conversation. Now the conversation must be explicitly joined by clicking a button in the chat tab. This prevents accidentally joining a room or even creating them when opening the details of a different file. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
feature: talk-sidebar ⬅️
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
approved these changes
Nov 7, 2019
nickvergessen
deleted the
do-not-immediately-join-the-conversation-in-files-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2347
Fixes #1366
Before as soon as the chat tab loaded if the file was shared the user automatically joined the conversation. Now the conversation must be explicitly joined by clicking a button in the chat tab. This prevents accidentally joining a room or even creating them when opening the details of a different file.
Note that in this current version the user always needs to explicitly click the Join button to see the chat messages (except if she changed to a different tab and went back to the Chat tab). It would be better if the chat messages are automatically shown if the conversation is already created and the user has already joined, but for now always having to join should be good enough (and better than accidentally creating/joining the conversation).