Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avatars for guests #313

Merged
merged 2 commits into from
May 8, 2017
Merged

Add avatars for guests #313

merged 2 commits into from
May 8, 2017

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented May 5, 2017

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@codecov
Copy link

codecov bot commented May 5, 2017

Codecov Report

Merging #313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #313   +/-   ##
=========================================
  Coverage     15.46%   15.46%           
  Complexity      274      274           
=========================================
  Files            18       18           
  Lines          1293     1293           
=========================================
  Hits            200      200           
  Misses         1093     1093

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040f8cf...347c8fe. Read the comment docs.

@nickvergessen
Copy link
Member

Having a guest named "Test" the admin still sees grey ? instead of colored T for me

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now

@nickvergessen nickvergessen merged commit 355885c into master May 8, 2017
@nickvergessen nickvergessen deleted the guest-avatars branch May 8, 2017 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants