[stable18] Guest name option is missing in calls #3169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content of AppSidebar only shows non-AppSidebarTab components when there is no AppSidebarTab. So as soon as a guest joined the call and the Chat was moved into a sidebar tab, the rename option was gone Signed-off-by: Joas Schilling <coding@schilljs.com>
marcoambrosini
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content of AppSidebar only shows non-AppSidebarTab components
when there is no AppSidebarTab. So as soon as a guest joined the call
and the Chat was moved into a sidebar tab, the rename option was gone
Backport of #3168