Always try to use microphone if camera failed #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting the local media it is first tried to get both microphone and camera and, if that fails, then it is tried to get only the microphone. However, this was done only when certain errors happened while trying to get both the microphone and the camera. Now, no matter the error, it is tried too to get only the microphone; if the media is still unavailable it will fail again, but this should help with some further scenarios not covered yet in the previously handled errors in which camera is not available but microphone is. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
feature: WebRTC 🚡
|
/backport to stable19 |
|
/backport to stable18 |
nickvergessen
approved these changes
Jun 8, 2020
This was referenced Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the local media it is first tried to get both microphone and camera and, if that fails, then it is tried to get only the microphone.
However, this was done only when certain errors happened while trying to get both the microphone and the camera. Now, no matter the error, it is tried too to get only the microphone; if the media is still unavailable it will fail again, but this should help with some further scenarios not covered yet in the previously handled errors in which camera is not available but microphone is.
Found while testing #3730 with Firefox 77 with microphone but no camera, as in that case a
NNotAllowedErrorwas triggered when resistFingerprinting was enabled (if it was not enabled thenNotFoundErrorwas triggered, which was already handled).Fix #154