Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍱 Dashboard adaption for Nextcloud 20 #3890

Merged
merged 13 commits into from
Aug 17, 2020
Merged

🍱 Dashboard adaption for Nextcloud 20 #3890

merged 13 commits into from
Aug 17, 2020

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jul 10, 2020

For nextcloud/server#21346

This implements a basic dashboard panel for Talk that lists the recent conversations.

  • Create conversation button in empty content view is non-functional
  • Figure out if we can join a call directly by clicking on the start call button
  • Show a loading placeholders
  • Properly style conversation list to match the talk sidebar

image

cc @nickvergessen @jancborchardt @ma12-co

@juliushaertl
Copy link
Member Author

@nickvergessen Is there a way to limit the results on https://nextcloud-talk.readthedocs.io/en/latest/conversation/#get-user-s-conversations in the request already? Any suggestion how to handle updates better than refetching every x seconds there?

lib/Dashboard/TalkPanel.php Outdated Show resolved Hide resolved
src/views/Dashboard.vue Outdated Show resolved Hide resolved
src/views/Dashboard.vue Outdated Show resolved Hide resolved
@nickvergessen
Copy link
Member

Is there a way to limit the results on https://nextcloud-talk.readthedocs.io/en/latest/conversation/#get-user-s-conversations in the request already?

No, and actually the results are not sorted at the moment on the server side. What would be a desired value, then we can add it. I would just like to not see this abused in other clients then by falsly assuming things on the limit and then asking for an offset etc.

Any suggestion how to handle updates better than refetching every x seconds there?

Not really, as I don't want to get signaling involved on the dashboard page. Also I think 5 second is way too frequent.

src/views/Dashboard.vue Outdated Show resolved Hide resolved
@nickvergessen nickvergessen changed the title Dashboard panel 🍱 Dashboard adaption for Nextcloud 20 Jul 28, 2020
@marcoambrosini
Copy link
Member

@juliushaertl could we have a "create new conversation" always and not only in the empty content? That way we could have a quick way to create a meeting like Jitzi and Zoom.
This could be a plus button similar to what we have in talk's conversations list:

Screenshot from 2020-08-03 10-51-56

Also, since each app has this "+" action, every dashboard list could have this, maybe it could appear when hovering the list? cc @jancborchardt

@jancborchardt
Copy link
Member

@ma12-co yup, exactly that is defined in the spec at nextcloud/server#20930

juliushaertl and others added 8 commits August 7, 2020 14:59
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

lib/Dashboard/TalkWidget.php Outdated Show resolved Hide resolved
lib/Dashboard/TalkWidget.php Show resolved Hide resolved
src/views/Dashboard.vue Outdated Show resolved Hide resolved
src/views/Dashboard.vue Show resolved Hide resolved
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

src/views/Dashboard.vue Outdated Show resolved Hide resolved
src/views/Dashboard.vue Outdated Show resolved Hide resolved
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member

Bildschirmfoto von 2020-08-17 16-03-57

Updated as discussed with @jancborchardt and @juliushaertl to show unread mentions and calls only and otherwise an empty content with the last 4 conversations.

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to get it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants