Fix empty call view position in sidebar #4429
Conversation
When the call view is shown in the Files app or public share page sidebar its direct children (the empty call view and the wrapper of videos) are expected to have an absolute position. However, as the empty call view had a relative position it was prepended before the call view padding (which defines the call view height) instead of fully covering it. When the call view is shown in the main Talk UI or in the video verification sidebar the call view has an explicit height attribute (rather than using a padding), so in this case it does not matter if the empty call view has a relative or absolute position. However, when the empty call view is shown in the grid it must use a relative position. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
|
/backport to stable20 |
|
not reproducible on master for me, neither in Firefox nor Chromium: I tried both making a call as guest and as regular user. what browser are you using ? I never noticed any call height changes before. |
Both Firefox and Chromium. But your screenshot is from the main Talk UI, not from a call in the Files app or the public share page sidebar which are the ones being fixed here ;-) |
|
oh... when I tested the sidebar mode I thought there was only a single video in the sidebar. |
There is no fullscreen mode from sidebar, I just cropped the screenshot to the call view area :-) See the tabs and the Leave call button below it ;-) |
|
I tried with NC 20 and can indeed see that the waiting screen is higher. Cool, now on the same page. |
|
I'll check these:
|
This is meant to be tested with server in fd178b92f63^ (as Talk master is not yet compatible with the Files sidebar changes introduced in nextcloud/server@fd178b9).
Although this became specially noticeable after #4408 it was already broken in previous versions (as the call view height was reduced when someone else joined the call), hence the backport to stable20 (it also happens in stable19 and stable18, so feel free to backport to them too if you want, but as it is "just" a style issue I only backported to stable20 to begin with).
Before:
After:
