-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @nextcloud/vue to 3.1.0 #4473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also cleanup old css hacks
spreed/src/components/RightSidebar/RightSidebar.vue
Lines 273 to 286 in fc1cbfc
/* Force scroll bars in tabs content instead of in whole sidebar. */ | |
::v-deep .app-sidebar-tabs { | |
height: calc(100% - 80px); | |
&__content { | |
overflow: hidden; | |
section { | |
height: 100%; | |
overflow-y: auto; | |
} | |
} | |
} |
I had a quick look at #4195 and I don't see any difference before and after the Vue update, so I'd say it's not a blocker. The PR in question needs further work and might require further changes in nextcloud-vue, for which we can do future releases + version bumps. |
@skjnldsv when I remove the whole block you mentioned (specifically, the overflow:hidden), there's a double scrollbar again. I compared the sidebar before and after the vue update, removing or adding the hack back, I saw no difference in behavior. |
Yeah, it's because of spreed/src/components/RightSidebar/RightSidebar.vue Lines 268 to 270 in 38d0870
You need to remove this as well. Please do not remove the outline! This is an accessibility feature and is here on purpose. Generally speaking you should not override components styling. If it's here, it's here on purpose and for all apps. |
Indeed. so this will reopen #2946 and we need to find a different solution for it, maybe rework the tab contents layout. Ideally the scroll container should start below the field instead of having the field floating and overlapping. This means having a scroll container even deeper inside the tab content and not using the tab content's own scroller. |
No need, just put the padding on the form, and it will have the background under it? |
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@skjnldsv easier said than done. I'll need some CSS (or even Vue) trickery to remove the padding on the parent ".app-sidebar-tabs__content" to add it back to the input field. But only do that when the participants tab is selected. |
never mind, was looking at the wrong element... |
9642617
to
5dfdffb
Compare
5dfdffb
to
51b5361
Compare
I've verified the scrolling with lots of messages in the files app sidebar and it worked fine! (had to use #4291 for testing) If CI is green I think we can move forward with this PR. |
Remove obsolete hacks for the right sidebar. Adjusted padding of search field to hide participants behind when scrolling, the former approach did not work any more. Signed-off-by: Vincent Petry <vincent@nextcloud.com> Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
51b5361
to
4c7b6a0
Compare
I forgot to verify the sidebar chat during a call (I only checked in the files app). |
This brings in:
Todos
potentially blocked by Use new app settings components #4195 (issues mentioned there)=> Bump @nextcloud/vue to 3.1.0 #4473 (comment)Tests
I did a quick test to see if all still works:
Obsoletes #4457