Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double scrollbar in call chat view #4493

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Remove double scrollbar in call chat view #4493

merged 1 commit into from
Oct 30, 2020

Conversation

PVince81
Copy link
Member

Fixes #4492

Seems this is already enough, tested on Firefox and Chromium.

@PVince81 PVince81 added this to the 💚 Next Major (21) milestone Oct 29, 2020
@PVince81 PVince81 self-assigned this Oct 29, 2020
@PVince81 PVince81 mentioned this pull request Oct 29, 2020
Closed
@skjnldsv

This comment has been minimized.

Sign in to view
@PVince81

This comment has been minimized.

Sign in to view
@PVince81

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@PVince81

This comment has been minimized.

Sign in to view
@PVince81

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@PVince81

This comment has been minimized.

Sign in to view
@PVince81

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv

This comment has been minimized.

Sign in to view
@PVince81
Copy link
Member Author

@skjnldsv fix for hidden-visually: nextcloud/server#23782

@PVince81 PVince81 mentioned this pull request Oct 29, 2020
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Oct 29, 2020 •
edited
Loading

I went for the cleanup way. I prefer to remove stuff that was not properly done that adding another line here :)

If you just want to fix this, without cleaning the other code (which is kinda unrelated to this pr, I went a bit overhead 🙈 )
Just fixing the new-message display is enough
Capture d’écran_2020-10-29_21-41-14
Capture d’écran_2020-10-29_21-41-20

works as well in the main chat view
Capture d’écran_2020-10-29_21-42-24

@PVince81

This comment has been minimized.

Sign in to view
@PVince81 @skjnldsv
Remove double scrollbar in call chat view
d3629ba 
Adjust stickiness of message form so it can work in both the regular
chat view and in the sidebar.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@PVince81 PVince81 force-pushed the bugfix/4492/call-remove-double-scrollbar branch from c5c927a to d3629ba Compare October 29, 2020 21:10
@PVince81
Copy link
Member Author

I've pushed the change for the fix that works without the extra cleanup, as the latter will need much more work.

Tested with:

@PVince81 PVince81 merged commit 630882f into master Oct 30, 2020
@PVince81 PVince81 deleted the bugfix/4492/call-remove-double-scrollbar branch October 30, 2020 08:18
@nickvergessen nickvergessen mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@PVince81 PVince81

Labels
3. to review design feature: call 📹 Voice and video calls
Projects
None yet
Milestone
v11.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

Double scrollbar in call view
2 participants
@PVince81 @skjnldsv