Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remember grid mode in sidebar call #4573

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Member

Always use speaker mode in sidebar calls, regardless what preference was
stored.

To test, merge with #4291

Not sure if this is enough. Strangely I see a black background for the other participant, regardless whether they joined or not (waiting), maybe there's more that needs fixing:
image

and the vuex inspector does tell me that we are not in grid mode.
Not sure what the expected behavior is here, I'll need to compare with Talk 10.0

@danxuliu

Always use speaker mode in sidebar calls, regardless what preference was
stored.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the bug/noid/no-remember-grid-in-sidebar-call branch from 24be400 to e3f1b42 Compare November 10, 2020 13:15
@PVince81
Copy link
Member Author

I found other regressions in sidebar view which are likely related, raised here: #4574

@danxuliu
Copy link
Member

I intended to use a different approach to fix this. Basically rewrite a bit the conditions in the CallView template so the speaker mode is always used if isSidebar === true (which I think is what was expected to happen already, but it does not due to some conflicting conditions).

This also has the benefit of not affecting any mode that the user may have set for that conversation in the main Talk UI.

@PVince81
Copy link
Member Author

I intended to use a different approach to fix this. Basically rewrite a bit the conditions in the CallView template so the speaker mode is always used if isSidebar === true (which I think is what was expected to happen already, but it does not due to some conflicting conditions).

This also has the benefit of not affecting any mode that the user may have set for that conversation in the main Talk UI.

Indeed, I had this in the back of my mind as well but wasn't sure.

@PVince81 PVince81 mentioned this pull request Nov 18, 2020
@PVince81
Copy link
Member Author

I've pushed the simpler fix to #4643 as it helps testing there and is anyway a one liner.

Closing as obsolete.

@PVince81 PVince81 closed this Nov 18, 2020
@PVince81 PVince81 deleted the bug/noid/no-remember-grid-in-sidebar-call branch November 18, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants