Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split "being in a room" from "calling" #459

Merged
merged 4 commits into from
Nov 3, 2017
Merged

Split "being in a room" from "calling" #459

merged 4 commits into from
Nov 3, 2017

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 31, 2017 •
edited
Loading

  • Add new endpoints
  • Split JS on the UI

Fix #431

@nickvergessen nickvergessen added 3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: signaling 📶 Internal and external signaling backends feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients labels Oct 31, 2017
@nickvergessen nickvergessen added this to the 3.0 (Nextcloud 13) milestone Oct 31, 2017
@nickvergessen
Copy link
Member Author

I'm a bit lost atm.
Should we start "Signaling" when joining a room, or only when joining a call?

@danxuliu danxuliu mentioned this pull request Nov 2, 2017
Merged
@fancycode
Copy link
Member

Should we start "Signaling" when joining a room, or only when joining a call?

I think it makes sense to establish the signaling connection once a user joins a room. That way all in-room notifications to the user (e.g. call started) could also be triggered through the standalone signaling server to avoid the polling overhead.

@nickvergessen nickvergessen force-pushed the joining branch 3 times, most recently from a75907f to f778ec3 Compare November 2, 2017 14:27
@nickvergessen
Copy link
Member Author

Should be good to go for version 1.0 now @Ivansss

@nickvergessen nickvergessen mentioned this pull request Nov 2, 2017
Closed
nickvergessen and others added 4 commits November 3, 2017 13:04
@nickvergessen @Ivansss
Split joining a room and joining a call API wise
eae71a3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @Ivansss
Fix the UI to correctly join the room and the call
88b639a 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@Ivansss
Added missing leave call function.
d70d455 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Rearrange steps in startSpreed function (fix problems joining a room …
218c1c6 
…from a url with room token).

Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss Ivansss merged commit 4c21ab3 into master Nov 3, 2017
@Ivansss Ivansss deleted the joining branch November 3, 2017 16:52
@danxuliu danxuliu mentioned this pull request Nov 9, 2017
Merged
@nickvergessen nickvergessen mentioned this pull request Nov 16, 2017
Merged
1 task
@fancycode fancycode mentioned this pull request Nov 20, 2017
Merged
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
@dependabot-preview
Merge pull request #459 from nextcloud/dependabot/npm_and_yarn/webpac…
694652d 
…k-cli-3.3.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

@fancycode fancycode Awaiting requested review from fancycode

Assignees
No one assigned
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: signaling 📶 Internal and external signaling backends feature: WebRTC 🚡 WebRTC connection between browsers and/or mobile clients
Projects
None yet
Milestone
2.9 (Nextcloud 13.0.0b1)
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @fancycode @Ivansss