[stable20.1] Replace blur with average color in video backgrounds #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
added
bug
feature: call 📹
backportbot-nextcloud
bot
requested review from
danxuliu,
marcoambrosini,
nickvergessen and
PVince81
|
src/components/CallView/Grid/Grid.vue and src/store/callViewStore.js are missing |
Safari suffers the same performance hit as Chromium when using the blur filter. However, Safari does not support using the blur filter on canvases, so the same workaround used for Chromium does not work in Safari. To solve this, and to still use a background with colors related to the avatar, the average of the colors in the avatar is used. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Before the average color for video backgrounds was locally stored in each VideoBackground instance. During a call different VideoBackground instances can be mounted and destroyed for the same participant (for example, when switching between speaker mode and grid view, or when a promoted speaker changes), so the previously calculated value was lost and the average color had to be recalculated every time that happened. Now the average colors are globally cached and shared between VideoBackground instances, so previously calculated values can be used by new VideoBackground instances. The global cache is cleared each time a call ends. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
For simplicity, as discussed, instead of using a workaround to still show blurred backgrounds in Chromium despite its performance bug in some systems now the average color is used instead. Moreover, as the CSS blur filter only works reliably in Firefox any other browser (which now also includes Chromium-based browsers, like the new Edge) uses the average color for the backgrounds. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
For consistency between browsers now the average color is shown in all cases, even if CSS blur filters work fine in Firefox. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The darkener was shown behind the background, so the background was not darkened. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
backport/4985/stable20.1
branch
from
7e66eec to
a521779
Compare
danxuliu
approved these changes
Jan 25, 2021
This was referenced Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #4985