Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nc-vue ActionCaption component #5303

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Mar 3, 2021

Upstream ActionCaption component

Screenshot from 2021-03-03 15-52-30

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

@PVince81
Copy link
Member

PVince81 commented Mar 4, 2021

@nickvergessen
Copy link
Member

#5248 needs a different fix though as I'm not willing to backport the vue update (seeing those jumping popup lately on master and sermo)

@marcoambrosini
Copy link
Member Author

#5248 needs a different fix though

==> #5328

@nickvergessen nickvergessen marked this pull request as draft April 9, 2021 11:28
@nickvergessen nickvergessen added this to the 💖 Next Major (22) milestone Jun 7, 2021
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini marked this pull request as ready for review June 17, 2021 15:47
@marcoambrosini marcoambrosini force-pushed the bugfix/5248/use-actioncaption-component branch from 8316690 to d575013 Compare June 17, 2021 15:48
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini merged commit def2934 into master Jun 17, 2021
@marcoambrosini marcoambrosini deleted the bugfix/5248/use-actioncaption-component branch June 17, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants