Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocols for TURN server not saved #535

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

danxuliu
Copy link
Member

Fixes #531

The TURN server values are now (tried to be) saved when the protocols are changed, like it is done when the server URL or the secret are changed.

Note that, just like with the server URL or the secret, all the required fields must be filled for the saving to succeed. Otherwise no value will be saved.

The TURN server values are now (tried to be) saved when the protocols
are changed, like it is done when the server URL or the secret are
changed.

Fixes #531

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu added this to the 3.0 (Nextcloud 13.0.0) milestone Dec 26, 2017
@danxuliu danxuliu requested a review from Ivansss December 26, 2017 16:28
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@Ivansss Ivansss merged commit 35512dc into master Jan 3, 2018
@Ivansss Ivansss deleted the fix-protocols-for-turn-server-not-saved branch January 3, 2018 08:52
marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Fix duplicate bakground color on action menu toggle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants