-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the owner update queries when the instance has no one2one rooms #537
Simplify the owner update queries when the instance has no one2one rooms #537
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Still failing with PostgreSQL: An exception occurred while executing 'UPDATE "oc_spreedme_room_participants" SET "participantType" = ? WHERE "userId" <> ''' with params [2]: SQLSTATE[42703]: Undefined column: 7 ERROR: column "userId" does not exist LINE 1: ...om_participants" SET "participantType" = $1 WHERE "userId" <... ^ HINT: Perhaps you meant to reference the column "oc_spreedme_room_participants.userid". |
That is quite awkward, we always used mixed cases: spreed/lib/Migration/Version2000Date20170707093535.php Lines 105 to 120 in bf36d30
Lines 93 to 115 in 40d90c3
I guess that means we have to replace camelcase with underscore or just lowercase everything. I just checked and no other app tries to use camelcase. So maybe this just never worked with postgres, or it's something from a doctrine upgrade. @Ivansss agreed? |
This fixes the migrations for postgres, but the live code still errors. Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
c4c424e
to
1b13e47
Compare
I fixed it now, so column names are using I did some quick tests (entering a call) and all worked on postgres now. @Ivansss can you run a little test with an app against it? |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
Fix #529