Fix raised hand handler not detached when peer is destroyed #5675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a memory leak, as the reference to the Peer object was retained forever by the webrtc object. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
bug
feature: frontend 🖌️
|
/backport to stable21.1 |
|
/backport to stable21 |
PVince81
deleted the
fix-raised-hand-handler-not-detached-when-peer-is-destroyed
branch
This was referenced May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a memory leak, as the reference to the Peer object was retained forever by the webrtc object.
How to test
console.log('Handling raised hand')as the first line inside_handleRaisedHandResult with this pull request
In the original window a single Handling raised hand message is printed in the console
Result without this pull request
In the original window three Handling raised hand messages are printed in the console