Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable21.1] Inject the preloaded user status into the avatar component #5694

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5288

Signed-off-by: Joas Schilling <coding@schilljs.com>
@PVince81
Copy link
Member

PVince81 commented Jun 1, 2021

To incorporate an addition to set preloaded user statuses.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member

PVince81 commented Jun 1, 2021

I've updated the lib to 3.7.0 here locally as it's the version with the addition we need.
To avoid regressions, we need to manually retest the following:

  • Allow to inject preloaded user statuses => no status requests when joining a room

  • Add a container property to popup components => unused on this branch, settings dialog popup still works

  • babel/present-env updates: retest with IE? => I've tested with Chromium and the supported IE version is the Edge based on Chromium, so should work...

  • Add disabled state to actions => unused

  • Add support for material design icons

    • verify that MD icons still work correctly (with the fix from v3.7.1)
  • retest datepicker due to vue2-datepicker update => lobby settings date picker still working

  • Use data of parent component in InputConfirmCanel subcomponent => unused

  • Recheck settings dialog + scrolling + layout => tested with audio/video settings dialog which has a navigation

    • Fixed settings navigation layout
    • Improved settings dialog layout
    • Make settings navigation list scrollable
  • Make sure we can check the classList on the node => unrelated

  • Update action hover feedback => tested, works

  • Improve multiselect tag => retested multiselect with media device selector and talk settings page

@PVince81
Copy link
Member

PVince81 commented Jun 1, 2021

okay, so raise hand icon was already broken on stable21.1... might be missing a separate backport:
Uploading image.png…

@PVince81
Copy link
Member

PVince81 commented Jun 1, 2021

this is the fix for the MD icons is nextcloud-libraries/nextcloud-vue#1741, so we need to go at least to 3.7.1 to also fix that unrelated regression

adjusting...

To include the fix for a regression with
material design action icons

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member

PVince81 commented Jun 1, 2021

I've updated the test results and verified that all related entries are still working.

Because why not ?

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member

PVince81 commented Jun 1, 2021

updated to 3.7.3 now because why not, as discussed.
no different in button appearance as we don't use single slot MD icons on stable21.1

@PVince81 PVince81 self-assigned this Jun 1, 2021
@nickvergessen nickvergessen merged commit 77ed87d into stable21.1 Jun 1, 2021
@nickvergessen nickvergessen deleted the backport/5288/stable21.1 branch June 1, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants