Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make links in chat clickable #579

Merged
merged 1 commit into from
Jan 12, 2018
Merged

make links in chat clickable #579

merged 1 commit into from
Jan 12, 2018

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jan 11, 2018

solves #533

screenshot_20180111_155633

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! :) Works nicely, whether in main view chat, sidebar chat, or for guests.

(Also very nice that https:// gets cut but http:// does not to call attention to it. :)

@jancborchardt jancborchardt added this to the 3.1 (Nextcloud 13.0.2/3) milestone Jan 11, 2018
@jancborchardt jancborchardt added the feature: chat 💬 Chat and system messages label Jan 11, 2018
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@danxuliu danxuliu force-pushed the format-links-in-chat branch from 7e14521 to 90865c3 Compare January 11, 2018 17:34
@danxuliu
Copy link
Member

I have amended your commit to fix a lint issue (OCP' is not defined).

@danxuliu
Copy link
Member

danxuliu commented Jan 11, 2018

Also very nice that https:// gets cut but http:// does not to call attention to it. :)

@jancborchardt Is that the technical user in you talking? :-P A normal user does not know nor care about HTTP and HTTPS; in fact I would even dare to say that it is confusing that some links include the protocol while others do not.

Personally I would prefer the protocol to be kept. Maybe now it is the technical user in me talking, but I think that people can associate something that looks like http:// to a webpage, even if they may not be able to correctly type http://.

Having said that, I do not have a strong opinion on this ;-)

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a different approach in mind to make links clickable using the rich formatting that will be introduced in #517

However, the changes introduced here are minimal and #517 is not ready yet, so we can merge this now and change it to the new system once it is ready ;-)

Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chat messages are not visible and I get JS errors:
Uncaught TypeError: Cannot read property 'plainToRich' of undefined

@blizzz
Copy link
Member Author

blizzz commented Jan 12, 2018

@Ivansss is your server up to date? needs master after nextcloud/server#7680

Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my fault 😬 server not updated

@Ivansss Ivansss merged commit 1892a6a into master Jan 12, 2018
@Ivansss Ivansss deleted the format-links-in-chat branch January 12, 2018 10:44
@jancborchardt
Copy link
Member

@danxuliu yes, it is slightly technical. However the underline is the important part which classifies it as a link. Anyhow I consider it detail. :)

marcoambrosini pushed a commit that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants