-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make links in chat clickable #579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! :) Works nicely, whether in main view chat, sidebar chat, or for guests.
(Also very nice that https:// gets cut but http:// does not to call attention to it. :)
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
7e14521
to
90865c3
Compare
I have amended your commit to fix a lint issue ( |
@jancborchardt Is that the technical user in you talking? :-P A normal user does not know nor care about HTTP and HTTPS; in fact I would even dare to say that it is confusing that some links include the protocol while others do not. Personally I would prefer the protocol to be kept. Maybe now it is the technical user in me talking, but I think that people can associate something that looks like http:// to a webpage, even if they may not be able to correctly type http://. Having said that, I do not have a strong opinion on this ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chat messages are not visible and I get JS errors:
Uncaught TypeError: Cannot read property 'plainToRich' of undefined
@Ivansss is your server up to date? needs master after nextcloud/server#7680 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my fault 😬 server not updated
@danxuliu yes, it is slightly technical. However the underline is the important part which classifies it as a link. Anyhow I consider it detail. :) |
solves #533