Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start with integration tests for invites #6427

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Start with integration tests for invites #6427

merged 5 commits into from
Nov 10, 2021

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 28, 2021 •
edited
Loading

  • Test that it doesn't work when federation is not enabled
  • Test remote participant is added to participant list
  • Test invite is sent
  • Test accepting an invite (any change for the inviter?)
  • Test declining an invite (is the remote participant removed?)
  • Test requesting the room as a remote participant
  • Test if remote participants can see the participant list

@nickvergessen nickvergessen added 2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 labels Oct 28, 2021
@nickvergessen nickvergessen self-assigned this Oct 28, 2021
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 29, 2021 •
edited
Loading

Next step

  • OCM-Provider does not know about the talk federation so does not return it and therefor does not handle the invitation

@nickvergessen
Copy link
Member Author

  • Database has unique index on token which needs to be extended to token+server_url

@gary-kim
Copy link
Member

This is just proving the usefulness of tests, isn't it.

I will get started on the messaging sharing after this is done.

@nickvergessen
Start with integration tests for invites
f4208ef 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Publish federation as initial state and load remote suggestions
0ad342d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the 💖 Next Major (23) milestone Nov 3, 2021
@nickvergessen
Copy link
Member Author

Not there yet, but let's merge this in between step as it fixes some issues and brings us closer without having merge conflicts at the end

@nickvergessen nickvergessen marked this pull request as ready for review November 3, 2021 13:48
@nickvergessen
Copy link
Member Author

Open tasks where moved to #5723

@nickvergessen
Fix protocol handling (should this really be done here?)
214cf55 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Correctly register the cloud federation provider
93a080c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix JS unit tests
a8fd7fc 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 7f18280 into master Nov 10, 2021
@nickvergessen nickvergessen deleted the integration-tests-for-invites branch November 10, 2021 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitormattos vitormattos vitormattos approved these changes

@gary-kim gary-kim Awaiting requested review from gary-kim

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐
Projects
None yet
Milestone
v13.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @gary-kim @vitormattos