-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "6318: fixed mention complete with mouse clicking" #6795
Revert "6318: fixed mention complete with mouse clicking" #6795
Conversation
/backport to stable23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
However, @marcoambrosini when reverting please describe why you are reverting :-) In this case I guess it is due to the event listener being set again and again when the input is focused, as it uses an arrow function, but better to have it explicit in the pull request description.
Could you also explain why the original code (before #6789) failed and why your change fixes it? I have tested just a few times and it worked, but it would be good to know where was the problem to test it in more detail, as the original code also worked some times.
Similarly, @nikola-gladovic, could you explain why your code fixed the issue too so both approaches can be compared?
Thanks :)
@danxuliu the commit message explanation is not good enough?? xD |
Increased the timeout in order to let the vue-at componentdo its magic before destroying it after a blur event on the advanced input. Signed-off-by: marco <marcoambrosini@pm.me>
6b456cf
to
4dd62b5
Compare
Ah, sorry, I should have looked there, indeed ;-) Relying on timeouts to do something is flaky, though... It would be interesting to understand why Nikola's approach also fixed the issue, as it could be a safer approach once the duplicated listener is fixed 🤔 |
But that is what the lib author mentions as solution: |
/backport 4dd62b5 to stable23 |
The backport to stable23 failed. Please do this backport manually. |
Reverts #6789
Fix #6318