Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Reparent file picker and viewer in fullscreen mode #6885

Merged
merged 1 commit into from
Feb 8, 2022

Commits on Feb 8, 2022

  1. Reparent file picker and viewer in fullscreen mode

    By default the file picker and the viewer are siblings of the fullscreen
    element, so they are not visible when in fullscreen mode. It is not
    possible to specify the parent nor to know when the file picker or the
    viewer were actually opened, so for the time being they are reparented
    if needed shortly after calling them.
    
    This is just a temporary hack until it is possible to specify the parent
    element, but that would require changes in the Vue library, the viewer
    and the server dialogs, so this horrible code will have to do for now.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu authored and backportbot[bot] committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    f6128f2 View commit details
    Browse the repository at this point in the history