Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable21] Fix tooltip, popups, dialogs... in fullscreen mode #6886

Merged
merged 7 commits into from
Feb 10, 2022

Commits on Feb 8, 2022

  1. Use container property to fix popups in fulllscreen mode

    Many popup components are usually appending themselves to the document
    body. This doesn't work in fullscreen mode where we use another
    component as the root.
    
    This fix sets the "container" property for all relevant popup components
    to make sure they can be visible in fullscreen mode.
    
    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    PVince81 authored and danxuliu committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    a59a67d View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. Fix order to reduce eslint warnings

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    nickvergessen authored and danxuliu committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    6946571 View commit details
    Browse the repository at this point in the history
  2. Make tooltips work in fullscreen mode

    Signed-off-by: Vincent Petry <vincent@nextcloud.com>
    PVince81 authored and danxuliu committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    4fd8a7c View commit details
    Browse the repository at this point in the history
  3. Fix container of modal and popup components when Talk is embedded

    The container of modal and popup components was always set to
    "#content-vue" to ensure that they will be properly shown in normal and
    fullscreen mode in the main Talk UI. However, when Talk is embedded in
    the Files app, the share page or the video verification there is no such
    element, so the container for the components could not be set and thus
    they were not shown.
    
    To solve this now the selector for the main container element is got
    from the store instead of being hardcoded, and the different UI modes
    set the appropriate value when initialized (or leave it undefined to use
    the default one, typically the body element, when a specific element is
    not needed).
    
    Note that this change applies too to some components that, right now,
    are only shown in the main Talk UI, but it was done for consistency and
    to make them "future-proof".
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    257624b View commit details
    Browse the repository at this point in the history
  4. Fix (partially) actions position when Talk is embedded in the Files app

    Using the default container causes the action menus in the Talk tab to
    be repositioned at wrong places when the menus are shown and the file
    list is scrolled. To address this (although it does not fully fix the
    issue, there are still some strange behaviours) the main container for
    Talk components used when Talk is embedded in the Files app is Talk tab.
    Besides that, both the container and the boundaries element of the
    actions are set to the Talk tab.
    
    Despite setting the main container this change does not affect other
    components (like the room selector) or slightly improves their behaviour
    (like the author avatar menu, which no longer appears outside the tab
    when scrolling).
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    f5a85e4 View commit details
    Browse the repository at this point in the history
  5. Fix JS CS

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    nickvergessen authored and danxuliu committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    d19c230 View commit details
    Browse the repository at this point in the history
  6. Reparent file picker and viewer in fullscreen mode

    By default the file picker and the viewer are siblings of the fullscreen
    element, so they are not visible when in fullscreen mode. It is not
    possible to specify the parent nor to know when the file picker or the
    viewer were actually opened, so for the time being they are reparented
    if needed shortly after calling them.
    
    This is just a temporary hack until it is possible to specify the parent
    element, but that would require changes in the Vue library, the viewer
    and the server dialogs, so this horrible code will have to do for now.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    b8eee2d View commit details
    Browse the repository at this point in the history