[stable23] Reduce sent information with disabled videos #7710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
Until now the stream locally shown was the stream sent to the other peers. Now there are separate streams for each case to be able to adjust them independently to work around specific browser behaviours. Nevertheless, the sent stream is a single stream shared by all sender peers, not a stream specific for each peer, so it is still generated in the local media class, just like the local stream. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
This ensures that other participants will receive a black video track when no visible video should be sent, even if the browser does not properly update a previously sent track when disabled or stopped. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Although the previous behaviour should be fine this aligns the behaviour of removed tracks with disabled and stopped tracks. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Sometimes Chromium does not render one or more frames to the stream captured from a canvas, so the canvas is now rendered several times and for a longer period to try to avoid that issue. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
backportbot-nextcloud
bot
added
bug
feature: call 📹
nickvergessen
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #7673