Various standalone signaling fixes. #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancycode
force-pushed
the
standalone-signaling-fixes
branch
from
ea01dab to
53baa4b
Compare
| @@ -275,6 +275,7 @@ protected function getInputStream() { | |||
| * https://github.com/nextcloud/spreed/wiki/Spreed-Signaling-API | |||
| * | |||
| * @PublicPage | |||
| * @NoCSRFRequired | |||
There was a problem hiding this comment.
Since this is OCS, it should not be necessary. If your requests fail, try adding a OCS-APIRequest: true header
There was a problem hiding this comment.
Thanks, didn't know about that header. If I set it, the @NoCSRFRequired can be removed - will remove that commit from the PR.
nickvergessen
approved these changes
May 8, 2018
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Otherwise messages like `refresh-participant-list` could be stored in the database even if standalone signaling is used. Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
fancycode
force-pushed
the
standalone-signaling-fixes
branch
from
53baa4b to
98b429e
Compare
|
Addressed your comment, thanks for the fast review. |
nickvergessen
added
3. to review
backport-request
bug
feature: signaling 📶
fancycode
added a commit
that referenced
this pull request
May 8, 2018
…ist. This avoids a conflict (introduced by #864) with the existing ´usersChanged` event which is triggered when the `inCall` status of a user has changed. Signed-off-by: Joachim Bauch <bauch@struktur.de>
This was referenced May 8, 2018
fancycode
added a commit
that referenced
this pull request
May 9, 2018
…ist. This avoids a conflict (introduced by #864) with the existing ´usersChanged` event which is triggered when the `inCall` status of a user has changed. Signed-off-by: Joachim Bauch <bauch@struktur.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues when using the standalone signaling server.
Should be backported to the current stable after landing.