-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load history and first set of new messages with 1 API request #8717
Conversation
Scenarios I tested:
All of them produce an acceptable state after loading the chat (better or equal to the previous behaviour). Some could still be improved in terms of scrolling off-set but that was already the case before, so I think we can keep it like that for now. Any (edge) cases I forgot? |
I would also test the reaction scenarios with a deleted message instead of a reaction, and with a command from another participant that is not visible for the user loading the chat instead of a reaction. |
Deleted messages are in the DOM, so they are not any different from normal messages
Similar to messages that are not in the DOM but in the store, completely non-existing messages will just fall back to the previous visible one, so should be covered as well. |
7d05367
to
0920722
Compare
ce65da3
to
53ed7c8
Compare
First usage will be entering a chat room where we get the context of the read marker Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…ffset Signed-off-by: Joas Schilling <coding@schilljs.com>
…age is not there Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
This allows some kind of A-B testing Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
53ed7c8
to
2be7deb
Compare
Could this be used (or easily extended) to solve #6046 and be used in mobile clients? |
We are doing it in the web now, if you did not open the conversation before :) |
Could we remove the stored messages for that conversation when we open it from search to get the correct context ? |
Put as an idea into #6046 ? |
Ref #8710
🚧 TODO
🏁 Checklist
docs/
has been updated or is not required