-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NcRichText component from @nextcloud/vue
#8904
Conversation
@nextcloud/vue
@nextcloud/vue
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
83ea3bf
to
2367864
Compare
Ready IMO. |
Jest is fully red? |
Here is the problem.
@juliushaertl @raimund-schluessler Any hint on why? Would it make sense to ignore some stuff with |
Well, by default jest ignores all packages in "transformIgnorePatterns": [
"/node_modules/(?!(.*)/)"
], as we do for To be honest, I wonder why this didn't happen with the standalone package |
Judging from all the changes in |
the package was excluded: Line 27 in be3a4f2
And mainly for that very same reason. |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
So I adjusted the list of packages to transform for jest in 5593202. It is quite extensive, and might change with a minor update of nextcloud/vue, but it works for now and doesn't require to transform all packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Jest is green;
Message
andQuote
rendered properly, import/order could be linted later;- We can close Bump @nextcloud/vue from 7.7.2 to 7.8.0 #8942 as duplicate
@raimund-schluessler @Antreesy Thanks! 💙 |
/backport to stable26 |
🎉 Circular dependency is definitely going down with the next
@nextcloud/vue
release which will includeNcRichText
and everything needed for the link picker and the reference widgets.refs nextcloud-libraries/nextcloud-vue#3841 nextcloud-libraries/nextcloud-vue#3812
I'll update
@nextcloud/vue
and set this to "ready for review" once the new release is out.