Fix json output #9067
Fix json output #9067
Conversation
|
/backport to stable26 |
Please add integration tests in https://github.com/nextcloud/spreed/tree/master/tests/integration/features/command |
#8404 Signed-off-by: Vitor Mattos <vitor@php.rio>
|
@nickvergessen writing the integrations tests I identified that the command to delete a command is only possible delete using the command id not the command name. I think that would be good implement an option to make possible delete by command name and turn the argument of command id optional to don't break the current input of this command. This small change will make the test more easy because we don't will need to use the output of add command to run the delete command. Can I implement this at this PR? https://github.com/nextcloud/spreed/blob/master/lib/Command/Command/Delete.php#L42-L48 |
|
Integration tests for add/delete can be done later (by raising a follow up ticket). |
Verified only if the output contain a common json simbols: list of
objects: [{
Signed-off-by: Vitor Mattos <vitor@php.rio>
vitormattos
force-pushed
the
bugfix/8404/fix-json-output
branch
from
d9063d8 to
cb537d6
Compare
Signed-off-by: Vitor Mattos <vitor@php.rio>
Will be a bit complex to match a string with quote because the regex ignore quotes: ([^"]*). If we change the regex don't will be possible found the end of string and maybe we will need to change the delimiter of the json string: https://stackoverflow.com/questions/8533943/cucumber-fill-in-a-field-with-double-quote-in-it#8534220 I changed to accept the argument also as PyStringNode and don't need do nothin more inside the method because the PyStringNode class have a magich methdo __toString(). Signed-off-by: Vitor Mattos <vitor@php.rio>
…string * Make the definition of steps more specific Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
🚧 TODO
🏁 Checklist
docs/has been updated or is not required