Calls are Conversations #919
Conversation
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
| @@ -126,7 +126,7 @@ protected function getRoom(IL10N $l, Room $room) { | |||
| return [ | |||
| 'type' => 'call', | |||
| 'id' => $room->getId(), | |||
| 'name' => $room->getName() ?: $l->t('a call'), | |||
There was a problem hiding this comment.
This should probably remain "a call" since it's of type call?
There was a problem hiding this comment.
Actually might be right, since notifier users different stuff for sending a call.
| @@ -140,7 +140,7 @@ protected function getFormerRoom(IL10N $l, $roomId) { | |||
| return [ | |||
| 'type' => 'call', | |||
| 'id' => $roomId, | |||
| 'name' => $l->t('a call'), | |||
|
Please check. |
|
👍 |
|
Looks good by me. |
|
If it’s a group conversation, we can directly show the name. So instead of:
it could be:
Because this is much quicker to read and also works better on mobile, especially for long user names. (And yeah, is the bolding possible?) |
Format is not sent nor enforced by the server (and it should not be); clients just receive {user} mentioned you in a group conversation: {conversation}, and it is up to them how to format the parameters. For example, the notifications app in the WebUI uses bold text for the conversation and user names, and it also shows the user avatar. |
|
@danxuliu ok, then ignore the bolding but let’s please shorten the text. :) |
Follow up #751
Activities:
{User} invited you to a call (before)
{User} invited you to a conversation (now)
Notifications:
{User} invited you to a group call (before)
{User} invited you to a group conversation (now)
{User} mentioned you in a group chat (before)
{User} mentioned you in a group conversation (now)