Fix tab header icons not shown #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The links in the tab header use an "icon-XXX" CSS class to define the icon that is shown next to it; icons are defined using a "background-image" CSS property in a ".icon-XXX" CSS selector. The links in the tab header have their own CSS rules to place them in the right position. Those CSS rules use a more specific selector than the one used for the icons, so the CSS rules for the links in the tab header override the CSS rules for the icons. Therefore, the "background-repeat" and "background-position" properties must be specified individually. Otherwise, if the general "background" CSS property is used the "background-image" from the icon would be overriden with a null image and thus no icon would be shown. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
backport-request
bug
design
feature: frontend 🖌️
Ivansss
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a regression introduced in ac9a949
Although in that commit the same change that caused this regression (replacing individual
background-XXXproperties with the generalbackgroundproperty) was applied too to.participantWithList li > ain that case it does not seem to have caused any problem (thebackgroundproperty in that element it looks like dead code without any effect, by the way).Before:
After:
