Add toggle to show and hide video from other participants #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "hidden" CSS class is not used in the avatar container of remote participants (only for the local one), so there is no need to remove it. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Before a user could disable her own video, but she had no way to disable the videos from other participants. This could be needed, for example, to alleviate the load on low-end systems, as in that case playing the video from remote participants could be too much for the system. Now a toggle is provided to manually show or hide the video of each remote participant if needed. The toggle is shown only when the remote participant is sending video; if the remote participant has disabled her own video (or does not have a camera) the toggle is hidden. Note that the toggle just shows or hides the HTML video element; it does not notify the remote participant to mute her video or to fully stop sending it. It is purely a local change that does not affect the remote clients. In the future this could be extended to involve the remote clients too, but for now just hiding the HTML video element notably reduces the CPU load in most systems (although unfortunately in some cases it does not). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
added
3. to review
backport-request
feature: frontend 🖌️
Ivansss
approved these changes
Jun 6, 2018
Ivansss
deleted the
add-toggle-to-show-and-hide-video-from-other-participants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before a user could disable her own video, but she had no way to disable the videos from other participants. This could be needed, for example, to alleviate the load on low-end systems, as in that case playing the video from remote participants could be too much for the system. Now a toggle is provided to manually show or hide the video of each remote participant if needed.
The toggle is shown only when the remote participant is sending video; if the remote participant has disabled her own video (or does not have a camera) the toggle is hidden.
Note that the toggle just shows or hides the HTML video element; it does not notify the remote participant to mute her video or to fully stop sending it. It is purely a local change that does not affect the remote clients. In the future this could be extended to involve the remote clients too, but for now just hiding the HTML video element notably reduces the CPU load in most systems (although unfortunately in some cases it does not).