Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

techdebt(controllers): Move talk annotations to attributes #9372

Merged
merged 2 commits into from
Apr 25, 2023
Merged

techdebt(controllers): Move talk annotations to attributes #9372

merged 2 commits into from
Apr 25, 2023

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 24, 2023 •
edited
Loading

🚧 Todo

🏁 Checklist

@nickvergessen nickvergessen added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants labels Apr 24, 2023
@nickvergessen nickvergessen added this to the 💙 Next Major (27) milestone Apr 24, 2023
@nickvergessen nickvergessen self-assigned this Apr 24, 2023
@nickvergessen nickvergessen force-pushed the techdebt/noid/move-talk-annotations-to-attributes branch from 8bd0464 to 6cc6e3f Compare April 24, 2023 14:28
@nickvergessen
feat(middleware): Move RequireCallEnabled annotation to attribute
b2b0bdf 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
techdebt(controllers): Migrate Talk annotations to attributes
f39a429 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/noid/move-talk-annotations-to-attributes branch from 6cc6e3f to f39a429 Compare April 25, 2023 10:12
@nickvergessen nickvergessen enabled auto-merge April 25, 2023 10:12
@nickvergessen
Copy link
Member Author

Test passes locally. So we'll keep an eye on it, to see if it is flaky

@nickvergessen nickvergessen disabled auto-merge April 25, 2023 11:57
@nickvergessen nickvergessen merged commit 4cc268d into master Apr 25, 2023
@nickvergessen nickvergessen deleted the techdebt/noid/move-talk-annotations-to-attributes branch April 25, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitormattos vitormattos vitormattos approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants technical debt
Projects
None yet
Milestone
17.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @vitormattos