Fix menu position for rooms and participants #941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default position (taking into account the CSS rules from the server) of the menu in the room and participant lists shows the arrow aligned to the center of the menu button. Moving it to the left is not needed, and it causes the arrow to be no longer aligned with the center of the button. Besides the contacts menu, which is already ignored in the CSS rule, the other only element that has the "bubble" CSS class is the menu in the participant list, so the rule can be safely removed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Ivansss
approved these changes
Jun 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
