Fix Viewer with Fullscreen mode toggle #9607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is on top of #9596 to test with both issues resolved. Rebase and merge after that PR merge. |
|
Time to rebase? |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/viewer-with-fullscreen-toggle
branch
from
479dbc1
to
42da355
Compare
|
/backport to stable27 |
|
One bug left |
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
nickvergessen
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🚧 Tasks
Fix
To work correctly in the Fullscreen mode, the Viewer should be mounted in Talk Vue app (
#content-vue). Currently, it is moved from the body to#content-vueonly once on Viewer open. It doesn't help when Fullscreen mode is enabled or disabled after the Viewer was opened.See also: #6879
This PR moves the Viewer to
watch.Remove a 1-second timeout
Currently, there is a 1000ms timeout to wait until Viewer was mounted. But 1 second too much.
This PR uses
nextTickto wait for one Vue scheduler iteration is enough.Now opening a file is almost 1000ms faster in Talk 😀
🏁 Checklist
docs/has been updated or is not required