feat(API): Allow to block older clients #9632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
2. developing
feature: api 🛠️
This was referenced May 30, 2023
nickvergessen
force-pushed
the
feat/desktop-201/allow-to-block-older-clients
branch
from
ada65d3
to
225f65a
Compare
ShGKme
approved these changes
May 31, 2023
Comment on lines
+48
to
+67
| /** | ||
| * Talk Desktop user agent but with a regex match for the version | ||
| * @see IRequest::USER_AGENT_TALK_DESKTOP | ||
| */ | ||
| public const USER_AGENT_TALK_DESKTOP = '/^Mozilla\/5\.0 \((?!Android|iOS)[A-Za-z ]+\) Nextcloud-Talk v([^ ]*).*$/'; | ||
| public const TALK_DESKTOP_MIN_VERSION = '0.6.0'; | ||
|
|
||
| /** | ||
| * Talk Android user agent but with a regex match for the version | ||
| * @see IRequest::USER_AGENT_TALK_ANDROID | ||
| */ | ||
| public const USER_AGENT_TALK_ANDROID = '/^Mozilla\/5\.0 \(Android\) Nextcloud\-Talk v([^ ]*).*$/'; | ||
| public const TALK_ANDROID_MIN_VERSION = '15.0.0'; | ||
|
|
||
| /** | ||
| * Talk iOS user agent but with a regex match for the version | ||
| * @see IRequest::USER_AGENT_TALK_IOS | ||
| */ | ||
| public const USER_AGENT_TALK_IOS = '/^Mozilla\/5\.0 \(iOS\) Nextcloud\-Talk v([^ ]*).*$/'; | ||
| public const TALK_IOS_MIN_VERSION = '15.0.0'; |
There was a problem hiding this comment.
Should we also update IRequest REs for version support in the server?
There was a problem hiding this comment.
Let's see what others think: nextcloud/server#38561
lib/Middleware/Exceptions/UnsupportedClientVersionException.php
Outdated
Show resolved
Hide resolved
Merged
5 tasks
ShGKme
approved these changes
May 31, 2023
ShGKme
approved these changes
May 31, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feat/desktop-201/allow-to-block-older-clients
branch
from
6183be4
to
d0ca6ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
426 Upgrade Requiredstatus code🚧 Tasks
🏁 Checklist
docs/has been updated or is not required