show feedback when WebRTC is not supported by the browser #97
Conversation
|
According to https://github.com/andyet/SimpleWebRTC there is a property So you should be able to query all sorts of properties from it. |
|
|
Current coverage is 6.93% (diff: 100%)@@ master #97 diff @@
========================================
Files 11 11
Lines 577 577
Methods 39 39
Messages 0 0
Branches 0 0
========================================
Hits 40 40
Misses 537 537
Partials 0 0
|
jancborchardt
force-pushed
the
unsupported-error
branch
from
9ed70d5 to
099d998
Compare
jancborchardt
changed the title
|
This is now ready for review :) |
| } | ||
| $('#emptycontent h2').text(message); | ||
| $('#emptycontent p').text(messageAdditional); | ||
| }); | ||
|
|
||
| if(!OCA.SpreedMe.webrtc.capabilities.support) { | ||
| console.log('WebRTC not supported', error); |
There was a problem hiding this comment.
error is not defined here (as reported by eslint)
There was a problem hiding this comment.
Ah right, just a boolean so no error message. Will just remove it.
|
lgtm if the undefined variable is fixed |
jancborchardt
force-pushed
the
unsupported-error
branch
from
099d998 to
bc6a593
Compare
rullzer
force-pushed
the
unsupported-error
branch
from
bc6a593 to
18641de
Compare
|
@Ivansss @MorrisJobke @rullzer @LukasReschke please review :) |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
unsupported-error
branch
from
1d355d7 to
6d499d7
Compare
|
I tested this and fixed another case in IE11 and Edge. |
|
👍 |
|
👍 |
What is the correct error handler? I suppose
on('WebrtcError'is wrong ;)Please help @fancycode @LukasReschke :)