Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] chore(deps) - remove unused dependencies #9979

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

Antreesy
Copy link
Contributor

Manual backport of #9975
Tested on web client, main + files sidebar (Chrome, Linux)

@Antreesy Antreesy added feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file javascript labels Jul 14, 2023
@Antreesy Antreesy added this to the 💚 Next Patch (27) milestone Jul 14, 2023
@Antreesy Antreesy requested a review from ShGKme July 14, 2023 13:43
@Antreesy Antreesy self-assigned this Jul 14, 2023
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the backport/9975/stable27 branch from e55e81a to 31baab6 Compare July 14, 2023 13:43
@ShGKme
Copy link
Contributor

ShGKme commented Jul 14, 2023

We usually do not backport dependency updates when not necessary (cc @nickvergessen)

@Antreesy
Copy link
Contributor Author

We usually do not backport dependency updates when not necessary

I think it's fine to make a cleanup, as we're going to support v.17 till the next release

@Antreesy Antreesy requested a review from nickvergessen July 17, 2023 14:03
@nickvergessen
Copy link
Member

Fine by me if you can garantee that it does not break anything under any circumstances for any user on any browser and OS.

Otherwise I'm all for being defensive and not changing deps unless there was a bug or sec fix we need

@Antreesy
Copy link
Contributor Author

Antreesy commented Jul 17, 2023

Fine by me if you can garantee that it does not break anything under any circumstances for any user on any browser and OS.

As being sad in initial PR, these dependencies don't affect a single line in our codebase (since the webdav version is also bumped to stable27), and also don't go to the production build, which we could judge from the build output (same before and after changes). If it'll help, I'll check the build more thoroughly to keep it safe from breaking changes

P.S. There is really no changes between productions builds (stable27 and this branch), all files are identical (performed a binary comparison for js folders):
image

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks convincing :)

@nickvergessen nickvergessen merged commit 55f089c into stable27 Jul 17, 2023
@nickvergessen nickvergessen deleted the backport/9975/stable27 branch July 17, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature: frontend 🖌️ "Web UI" client javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants