Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make monthly report time insensitive #126

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Make monthly report time insensitive #126

merged 1 commit into from
Mar 4, 2022

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Mar 4, 2022

I'm guessing that the collectors might be slightly expensive, so running during maintenance window might be preferable.

@PVince81
Make monthly report time insensitive
17190f3 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 self-assigned this Mar 4, 2022
nickvergessen
nickvergessen approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really expensive, but sane never the less

@PVince81 PVince81 merged commit 92691f2 into master Mar 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the monthly-report-time-insensitive branch March 4, 2022 10:49
@nickvergessen
Copy link
Member

Actually we should not move this, otherwise our server might be ddosed as the requests to the static server are not spreaded anymore.

@PVince81
Copy link
Member Author

PVince81 commented Mar 4, 2022

Actually we should not move this, otherwise our server might be ddosed as the requests to the static server are not spreaded anymore.

good point!

@PVince81 PVince81 mentioned this pull request Mar 4, 2022
Merged
@nickvergessen nickvergessen mentioned this pull request Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@PVince81 PVince81

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PVince81 @nickvergessen