move settings to a seperate page in the admin settings #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @returns string | ||
| */ | ||
| public function getID() { | ||
| return 'surveyclient'; |
There was a problem hiding this comment.
Use the app id? so with _
8 tasks
schiessle
force-pushed
the
move-to-new-admin-settings
branch
from
a448e35 to
d3c7eb7
Compare
|
@nickvergessen fixed... 😉 |
1 task
| @@ -33,7 +33,7 @@ protected function run($argument) { | |||
| ->setDateTime(new \DateTime()) | |||
| ->setSubject('updated') | |||
| ->setObject('dummy', 23) | |||
| ->setLink($urlGenerator->getAbsoluteURL('index.php/settings/admin#usage-report')); | |||
| ->setLink($urlGenerator->getAbsoluteURL('index.php/settings/admin/survey_client')); | |||
There was a problem hiding this comment.
you can also use linkToRoute() instead, makes you robust against possible future url changes.
|
One suggestion, works, 👍 |
|
needs rebase |
schiessle
force-pushed
the
move-to-new-admin-settings
branch
from
d3c7eb7 to
2f7822f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport to stable10 as soon as nextcloud/server#796 is backported