-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): Add Nextcloud 29 support on master #207
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
Workflows should be updated from nextcloud/.github and CI requirement adapted. I can do it but I’d need admin rights, @nickvergessen Do you have those? |
(Looking into this because this application is shipped and it breaks |
Looking at https://github.com/nextcloud/survey_client/blob/master/.github/workflows/psalm.yml I guess it is quite old and updating it would add the missing check ^^ But I can remove it for now |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
I pushed an update of the workflow but I think there is no summary in this one so requirement will need to be adapted anyway. |
I’ll update phpunit workflows as well 🤷 |
updated static away from summary |
Modern workflows are too smart 😆 Deleting the workflow as there are no unit tests. |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
403482f
to
3515e88
Compare
Recommended step is to run it with |
Signed-off-by: Joas Schilling coding@schilljs.com