Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/v0.3.0 #111

Merged
merged 89 commits into from
Feb 21, 2023
Merged

Feat/v0.3.0 #111

merged 89 commits into from
Feb 21, 2023

Conversation

datenangebot
Copy link
Collaborator

This is a PR draft for the upcoming tables release v0.3.0 with the invitation for testing.
With this release are some bugs fixed and the table is replaced with an own vue component.

Known bugs:

Missing features due to the table replacement

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
appinfo/info.xml Outdated Show resolved Hide resolved
css/grid.css Outdated Show resolved Hide resolved
css/style.css Outdated Show resolved Hide resolved
lib/Db/Table.php Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/store/data.js Outdated Show resolved Hide resolved
<tr v-if="row" :class="{ selected }">
<td><NcCheckboxRadioSwitch :checked="selected" @update:checked="v => $emit('update-row-selection', { rowId: row.id, value: v })" /></td>
<td v-for="col in columns" :key="col.id">
<TableCellProgress v-if="col.type === 'number' && col.subtype === 'progress'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to declare those as constants somewhere central

@juliusknorr
Copy link
Member

One more thing found when testing:

  • Text columns should probably be limited in size:
    Screenshot 2023-02-04 at 00 34 23

@datenangebot datenangebot force-pushed the feat/v0.3.0 branch 2 times, most recently from c9b1228 to 16c4947 Compare February 15, 2023 14:00
Florian Steffens and others added 7 commits February 21, 2023 11:59
Signed-off-by: Florian Steffens <florian@nextcloud.com>
* tests(psalm): Add psalm with current baseline

Signed-off-by: Julius Härtl <jus@bitgrid.net>

* tests(psalm): Add nextcloud/ocp

Signed-off-by: Julius Härtl <jus@bitgrid.net>

* tests(psalm): mute some warnings about external dependencies and magic methods for now

Signed-off-by: Julius Härtl <jus@bitgrid.net>

* tests(psalm): Fix some annotations to improve static analysis

Signed-off-by: Julius Härtl <jus@bitgrid.net>

* fix(ColumnController): Use proper parameter order for column deletion

Signed-off-by: Julius Härtl <jus@bitgrid.net>

* ci(psalm): Run psalm check on github actions

Signed-off-by: Julius Härtl <jus@bitgrid.net>

* Bump @nextcloud/eslint-config from 8.1.5 to 8.2.0

Bumps [@nextcloud/eslint-config](https://github.com/nextcloud/eslint-config) from 8.1.5 to 8.2.0.
- [Release notes](https://github.com/nextcloud/eslint-config/releases)
- [Changelog](https://github.com/nextcloud/eslint-config/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/eslint-config@v8.1.5...v8.2.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/eslint-config"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump @nextcloud/vue from 7.3.0 to 7.4.0

Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 7.3.0 to 7.4.0.
- [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md)
- [Commits](nextcloud-libraries/nextcloud-vue@v7.3.0...v7.4.0)

---
updated-dependencies:
- dependency-name: "@nextcloud/vue"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix(l10n): 🔠 Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

* fix: Use NcContent component instead of div

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nextcloud bot <bot@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
…rows, edit button for rows

Signed-off-by: Florian Steffens <florian@nextcloud.com>
…t, it could not be avoided to touch also some other stuff

not yet working:
- delete selected rows
- import data from csv & clipboard

Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Florian Steffens and others added 24 commits February 21, 2023 11:59
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Florian <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
…ss via cli

Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
…th stars column-type

Signed-off-by: Florian Steffens <florian@nextcloud.com>
Signed-off-by: Florian Steffens <florian@nextcloud.com>
@datenangebot datenangebot marked this pull request as ready for review February 21, 2023 12:18
@datenangebot datenangebot merged commit 04269de into main Feb 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/v0.3.0 branch February 21, 2023 12:19
@juliusknorr
Copy link
Member

🎉

@jakobroehrl jakobroehrl mentioned this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants