enh: warn during table manager promotion/demotion #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjeck
force-pushed
the
warn-table-manager
branch
from
8cf9e5c to
74f35ef
Compare
enjeck
changed the title
enjeck
force-pushed
the
warn-table-manager
branch
from
74f35ef to
78bbc66
Compare
|
Now, there's a confirmation screen that warns about tables when a user attempt to promote to a manager: There's also a warning display after demotion. Would like to hear what @nextcloud/designers think :) Initially, I attempted to fetch all Applications and check if the table is in use (so that we only show the warning if there table is actually used in some Application), but that seemed to be getting to complicated. Pushed unfinished code to main...warn-demote-check-apps |
juliusknorr
approved these changes
Dec 5, 2024
Not really. I can change to the 'warning' color then |
enjeck
force-pushed
the
warn-table-manager
branch
from
807390d to
d7785c5
Compare
|
Now looks like so:
|
|
@enjeck looks good! let's just right align the cancel button like in other dialogs and we're golden. |
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
warn-table-manager
branch
from
d7785c5 to
a259596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.