enhancement: UI fixes for create/edit row dialogs #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjeck
force-pushed
the
create-row-ui-fix
branch
from
87dccc5 to
531cad1
Compare
blizzz
requested changes
Feb 19, 2025
src/modules/modals/EditRow.vue
Outdated
| @@ -6,7 +6,7 @@ | |||
| <NcDialog v-if="showModal" | |||
| data-cy="editRowModal" | |||
| :name="t('tables', 'Edit row')" | |||
| size="large" | |||
| size="normal" | |||
There was a problem hiding this comment.
That was done intentionally in #1611
There was a problem hiding this comment.
The rich text editor looks weird though. If we're keeping this size, then we change the "Create row" modal size too for consistency
|
Adding @marcoambrosini for review. Maybe the size of the modals need a discussion. Or maybe expand/narrow buttons, maybe remembering users preference (in browser). |
juliusknorr
added
bug
|
Please remember to add labels |
|
We talked about this in our 1on1 with @enjeck, I think it's fine to keep size large for all these dialogs |
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
create-row-ui-fix
branch
from
531cad1 to
814f3a1
Compare
Signed-off-by: Cleopatra Enjeck M. <patrathewhiz@gmail.com>
Add labels where? The dialogs themselves already have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Before
After