Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Share with ..." function (Android) #308

Closed
stullekovski opened this issue Sep 12, 2018 · 17 comments · Fixed by #1252
Closed

"Share with ..." function (Android) #308

stullekovski opened this issue Sep 12, 2018 · 17 comments · Fixed by #1252
Assignees
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request feature: 🗨️ chat good first issue Good for newcomers
Milestone

Comments

@stullekovski
Copy link

Hi
I was wondering why I can't find Nextcloud Talk in my list when I try to share sth. like in my Brave Browser (LOS 15.1)? Did I miss something or this right?
I would be really happy if there'll be this feature to simply share links directly with my contacts.
Thanks a lot!

@mario
Copy link
Contributor

mario commented Sep 14, 2018

Good idea. I'll add it eventually!

@mario mario added this to the v4.1 milestone Dec 7, 2018
@mario
Copy link
Contributor

mario commented Jan 16, 2019

#312 (comment)

@szaimen
Copy link

szaimen commented May 31, 2019

Any update on this?

@szaimen
Copy link

szaimen commented Oct 5, 2019

This feature could probably be implemented before #435 and could work like that:

1 Open a website in the browser
2 Click on "share"
3 Select nectcloud-talk from the sharing list
4a Press short to select one chat that you want to share the link with and press afterwards okay or cancel in the popup
or
4b Press long to get into batch-mode to select one or more chats that you want to share the link with and press afterwards okay

@jancborchardt jancborchardt added the enhancement New feature or request label Jan 20, 2020
@jakobroehrl
Copy link

jakobroehrl commented Apr 18, 2020

Maybe it helps to see how the deck app has implemented it: https://github.com/stefan-niedermann/nextcloud-deck/blob/master/app/src/main/java/it/niedermann/nextcloud/deck/ui/sharetarget/ShareTargetActivity.java (stefan-niedermann/nextcloud-deck@fc711d8)

Edit by @stefan-niedermann Updated link to Deck app

@jancborchardt jancborchardt added the good first issue Good for newcomers label Apr 20, 2020
@Spartachetto
Copy link

I confirm that when I share something e.g. from my browser I have in the list of the available apps:

  • Nextcloud app
  • Nextcloud Notes app
  • Nextcloud Deck app
  • Nextcloud Bookmarks app

yet no Nextcloud Talk app, which seems so strange....

@daffydock
Copy link

Hello.

Is this an item that is still being actively looked into?

@dan0xii
Copy link
Contributor

dan0xii commented Oct 5, 2020

I am working on it and have a basic implementation for text but not images.

@mnlipp
Copy link

mnlipp commented Oct 19, 2020

What's the relationship between this issue and #435? Are these duplicate efforts? Maybe it would speed things up if there was only one joined approach. (As mentioned many times, not having the talk app in the list of apps for sharing images, links etc. makes the app absolutely useless for daily usage.)

@tobiasKaminsky
Copy link
Member

@mnlipp I think it is the same. But as only @dan0xii is working on this feature, it does not duplicate any efforts…

@mat-l
Copy link

mat-l commented Feb 27, 2021

Sharing files in the browser is working fine. Therefore the backend should be ready right? nextcloud/spreed#2891

Any updates here about the mobile apps for daily use?

@nickvergessen
Copy link
Member

Mobile apps can now upload items in the chat view, the share dialog to share items form other apps will follow later this year

@nickvergessen nickvergessen added the 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) label Apr 19, 2021
@nickvergessen nickvergessen removed this from the vX.Y+2 milestone Apr 19, 2021
@nickvergessen nickvergessen added this to the v12.0.0 milestone May 10, 2021
@stefan-niedermann
Copy link
Member

@mahibi awesome! Can you tell me in which version this feature will be published? 🙂

@mahibi
Copy link
Collaborator

mahibi commented May 25, 2021

i guess this will be published with v12.

and thanks to @dan0xii ! your branch gave some inspirations how things could be implemented.. 👍

@stefan-niedermann
Copy link
Member

I roughly scanned the code and i am wondering whether also sharing plain text (for example when selecting a word) into the Talk app is supported by #1252 ?

I have the impression that this is only about files, but i am not sure.
Shall i open a separate issue or is this feature already included?

@nickvergessen
Copy link
Member

Sharing text works.

But on the share dialog I can not change the current active account.

@mahibi
Copy link
Collaborator

mahibi commented May 25, 2021

But on the share dialog I can not change the current active account.

yes that's true indeed and could be a follow up PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request feature: 🗨️ chat good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.