Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File upload #2891

Merged
merged 8 commits into from
Feb 21, 2020
Merged

File upload #2891

merged 8 commits into from
Feb 21, 2020

Conversation

marcoambrosini
Copy link
Member

Signed-off-by: Marco Ambrosini marcoambrosini@pm.me

@marcoambrosini marcoambrosini added this to the 💚 Next Major (19) milestone Feb 3, 2020
@marcoambrosini marcoambrosini self-assigned this Feb 3, 2020
@marcoambrosini marcoambrosini changed the title Add actions File upload Feb 3, 2020
@marcoambrosini marcoambrosini force-pushed the feature/1129/file-upload branch 2 times, most recently from 0070118 to 6559606 Compare February 19, 2020 08:49
@nickvergessen nickvergessen mentioned this pull request Feb 19, 2020
Merged
2 tasks
@marcoambrosini
Add actions
4d1c616 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini
Add hidden browser file-picker
2dba83a 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini force-pushed the feature/1129/file-upload branch from 6559606 to 19babad Compare February 20, 2020 07:52
@marcoambrosini
Add dav client
5bd9980 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini
Upload files to root user directory
2b56d02 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini force-pushed the feature/1129/file-upload branch from 19babad to 2b56d02 Compare February 20, 2020 11:46
@marcoambrosini marcoambrosini marked this pull request as ready for review February 20, 2020 12:31
nickvergessen
nickvergessen requested changes Feb 20, 2020
View reviewed changes
src/components/NewMessageForm/NewMessageForm.vue Outdated Show resolved Hide resolved
src/components/NewMessageForm/NewMessageForm.vue Outdated Show resolved Hide resolved
src/components/NewMessageForm/NewMessageForm.vue Outdated Show resolved Hide resolved
src/components/NewMessageForm/NewMessageForm.vue Outdated Show resolved Hide resolved
src/components/NewMessageForm/NewMessageForm.vue Outdated Show resolved Hide resolved
@nickvergessen nickvergessen added the feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings label Feb 20, 2020
@marcoambrosini marcoambrosini force-pushed the feature/1129/file-upload branch from 59b54cc to 7bf9c61 Compare February 20, 2020 15:57
@marcoambrosini
Improve menu wording
9b778bd
@marcoambrosini
Show error when upload fails
31437e5 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini marcoambrosini force-pushed the feature/1129/file-upload branch from 7bf9c61 to 31437e5 Compare February 20, 2020 16:03
@marcoambrosini
Display the uploaded file in the chat
a01c6bc 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
@marcoambrosini
Add documentation
ec105b8 
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
nickvergessen
nickvergessen approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but currently upload is always overwriting. I think we should detect duplicates and append " (2)" like with shares

@marcoambrosini marcoambrosini merged commit e9ce0ef into master Feb 21, 2020
@marcoambrosini marcoambrosini deleted the feature/1129/file-upload branch February 21, 2020 10:29
@szaimen
Copy link
Contributor

szaimen commented Feb 21, 2020

🎉

@marcoambrosini marcoambrosini mentioned this pull request Feb 24, 2020
Closed
@mat-l
Copy link

mat-l commented Feb 27, 2021

Would love to see this feature in the mobile apps. 😍😎

@mat-l mat-l mentioned this pull request Feb 27, 2021
Closed
@Antreesy Antreesy mentioned this pull request Jul 14, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
v9.0.0-beta1
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoambrosini @szaimen @mat-l @nickvergessen