File upload from within a chat

[nickvergessen]

Subtasks:

• File picker
• Upload
• Displaying images inline

[ArtificialOwl]

Not sure what is your ideas, but could be nice to be able to upload within the file picker and also directly in the chat; and the file is stored in a folder specific to the app

[Ivansss]

That's the idea we have @daita :)
There will be 2 options when you press the '+' button.

• Share a file (that you already have in your NC)
• Upload a file (that will be stored in a specific folder and shared directly in the chat)

[Ozzie76]

Just did a pilot and this came up as one of the 2 missing features on mobile apps.

[jancborchardt]

Here’s wording suggestions for the + Add menu:

• ⬆️ Upload from device (icon-upload)
• 📁 Add from Nextcloud (= branding variable, icon-folder)

[JLueke]

Where would the uploaded files be stored in case of one-to-one chat or group chat?

Was the idea to upload the file and then share it automatically with the discussion partner / group?

[jancborchardt]

Discussed about wording and storing files with @nickvergessen @Ivansss:

• Updated our wording decision in the comment at File upload from within a chat #1129 (comment)
• Files are stored in a folder in the Files app root (of the person who uploaded the file) called "Talk files". (Compare to "WhatsApp images" on mobile.)
• When I upload a file in Talk and it gets added to my "Talk files" folder, the file will also get shared in the background with the other participants of the call read-only. Same for files from others, they get shared with me into the "Talk files" folder.

[JLueke]

I think storing all the files of all the chats in one folder gets messy really quick. Sure there is the extra option to share an existing file somewhere in you're structure, but why not combine it for "Upload from device".

1. Specify the destination where the file should be uploaded to
2. Upload file
3. Share file automatically with the chat

I think that otherwise it's just a user unfriendly detour to first upload a file in the files app and then return to the chat to share it.

[jancborchardt]

Specify the destination where the file should be uploaded to

This step already makes it more complicated than "it just works". ;)

To be specific: The whole "saving it in a root folder" is just an addition we do because we happen to have Files. The important thing is that you can simply send a file in the conversation, either from your Nextcloud or your device. Where they are specifically stored is imolementation detail (they could also just be somewhere in a non-visible location – but different topic).

[manswiss]

And please add the avaibility of add file with drag&drop. I would use nextcloud&talk in our company, but without the feauture to add an local file with drag&drop to a group chat, i will have no chance. This is a basic requirement in our company.

[ldesgrange]

Hi, that would be a nice feature, looking at how my colleagues work, being able to copy/paste into the chat would be nice too (they tend to copy some content generated on the fly (like screenshots) and paste them directly without saving the file somewhere first).

[makayabou]

I think storing all the files of all the chats in one folder gets messy really quick

is True . Then

Specify the destination where the file should be uploaded to

is good. But

This step already makes it more complicated than "it just works". ;)

is True also!
In my opinion, what would be great is a folder Talk-files with a subfolder for each conversation.
And in it, we have files that have been uploaded from local storage, and also links to files stored in Nextcloud Files and shared in the conversation.
It's kind of linked to another issue I submitted : #1577
What is common here is the need to centralize files linked to a room. In a working group, each conversation could be a project.

[Pedulla]

With the iminent demise of HangOut, this is a must have!

[DeeeeLAN]

In my opinion, what would be great is a folder Talk-files with a subfolder for each conversation.
And in it, we have files that have been uploaded from local storage, and also links to files stored in Nextcloud Files and shared in the conversation.

This is the obvious solution to me. It "just works", but also keeps the file upload system organized and easy to clean up.

[nickvergessen]

Upload is explained in #1811 (comment)

[fsxadmin]

we added this feature, and it goes into your home folder. im look for a dev to port it to the latest nextcloud!
https://github.com/fsxadmin/spreed

[nickvergessen]

Hi @fsxadmin any bigger reason why you forked it and added the feature there, instead of putting it in our code base?
I will invite you to our org and add you to the talk team, then you can send future features directly as a pull request. Also feel free to jump into our public conversation if you need help with anything: https://cloud.nextcloud.com/call/c7fz9qpr

[nickvergessen]

I tried to find the change in your repo, but I couldn't find anything. All your branches seem to have no additional commits. Do you mind to point out where the changes are? Otherwise it's hard for us to help porting it to the newest version

[fsxadmin]

@nickvergessen i will speak with my devs and see where the code is. We have had it working on 16 and 6 versions respectively and are still using it. It would be great to add to the main code base! More info soon.

[fsxadmin]

@nickvergessen
https://github.com/omarusman/talk

[fsxadmin]

Let me know if the code is good enough; we can get Omar working on this project again if you find the code to be good. We also modified alerts for calls, created “temp “ messages that go away after a minute for privacy, and other features.

[nickvergessen]

I created a draft PR to just copy everything over:
#2852

From there we can see more easily what is there and what we should pick to the newest version

[nickvergessen]

@fsxadmin I failed to be able to get that stuff extracted. It seems Omar added the code in a "initial" commit together with the Talk 5.0.2 code
If he is willing to work on it again and send a proper patch on the new Vue frontend, that would be highly appriciated.

[pierrecorsini]

We are not using Talk but another open source team chat solution. Mostly because this feature is missing. Being able to drag drop files to chat is a minimum. The next step is so allow smarter external content display (links with thumbnail + desc, maps) and allow (bidirectional) web hooks.

[marcoambrosini]

Done in #2891