Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use photo picker #4313

Open
mahibi opened this issue Oct 4, 2024 · 3 comments
Open

Use photo picker #4313

mahibi opened this issue Oct 4, 2024 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request

Comments

@mahibi
Copy link
Collaborator

mahibi commented Oct 4, 2024

We need to implement photo picker as Google might demand it via playstore.

Lint warnings because we use android.permission.READ_MEDIA_IMAGES and android.permission.READ_MEDIA_VIDEO: https://googlesamples.github.io/android-custom-lint-rules/checks/SelectedPhotoAccess.md.html

https://android-developers.googleblog.com/2023/04/photo-picker-everywhere.html

https://developer.android.com/training/data-storage/shared/photopicker

@mahibi mahibi added 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request labels Oct 4, 2024
@mahibi mahibi added this to the 20.1.0 milestone Oct 4, 2024
@mahibi mahibi removed this from the 20.1.0 milestone Nov 29, 2024
@Smarshal21
Copy link
Member

Smarshal21 commented Mar 1, 2025

@mahibi I’d like to work on this issue regarding implementing the Photo Picker, as Google might require it for Play Store compliance.

One concern: We currently have a cropping functionality after picking an image, but Google’s Photo Picker doesn’t provide built-in cropping. What would you recommend for handling this? Should we integrate a third-party library or do you have another approach in mind?

Let me know your thoughts!

@mahibi
Copy link
Collaborator Author

mahibi commented Mar 3, 2025

I’d like to work on this issue...

Thanks to offer help @Smarshal21 !
However there are currently overall discussions how the photos should be picked, see nextcloud/spreed#14414 (comment)

I would vote for the photo picker but it's not my decision. We will have to wait a bit more for decisions..

@Smarshal21
Copy link
Member

I’d like to work on this issue...

Thanks to offer help @Smarshal21 ! However there are currently overall discussions how the photos should be picked, see nextcloud/spreed#14414 (comment)

I would vote for the photo picker but it's not my decision. We will have to wait a bit more for decisions..

Thanks for the update, @mahibi! That makes sense—I'll keep an eye on the discussions around the photo selection approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants